From 0a12f5470af9c72cd1e315fc039f0ba07634ba77 Mon Sep 17 00:00:00 2001 From: Florian Hartwich Date: Wed, 28 Mar 2018 15:07:08 +0200 Subject: [PATCH] use var for repeatitive calculation --- .../campaign-player-detail.component.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/static/src/app/statistic/campaign-player-detail/campaign-player-detail.component.ts b/static/src/app/statistic/campaign-player-detail/campaign-player-detail.component.ts index 415ae83..9e206bf 100644 --- a/static/src/app/statistic/campaign-player-detail/campaign-player-detail.component.ts +++ b/static/src/app/statistic/campaign-player-detail/campaign-player-detail.component.ts @@ -96,12 +96,13 @@ export class CampaignPlayerDetailComponent implements OnInit { this.reviveData = this.assignData(this.yAxisRevive, 'revive'); this.captureData = this.assignData(this.yAxisCapture, 'flagTouch'); - this.kdRatio = parseFloat((this.totalKills / (this.totalDeath === 0 ? 1 : this.totalDeath)).toFixed(2)); + const totalDeathDiv = this.totalDeath === 0 ? 1 : this.totalDeath; + this.kdRatio = parseFloat((this.totalKills / totalDeathDiv).toFixed(2)); if (this.kdRatio > 1) { this.maxKd = this.kdRatio * 1.7; } - this.respawnDeathRatio = parseFloat((this.totalRespawn / (this.totalDeath === 0 ? 1 : this.totalDeath)).toFixed(2)); + this.respawnDeathRatio = parseFloat((this.totalRespawn / totalDeathDiv).toFixed(2)); this.sumData = [ {